Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: Kona 2nd Gen Port #30679

Closed
wants to merge 75 commits into from
Closed

Conversation

royjr
Copy link
Contributor

@royjr royjr commented Dec 10, 2023

Note

The 2024 Kona may be similar to 2024 Elantra, 2024 Sonata, 2024 Sonata, 2024 Sorento

Checklist

  • add to RELEASES.md
  • generate DOCS.md
  • add specs to interface.py
  • add fingerprint to values.py
  • add default values to override.yaml
  • route (stock)
  • route (openpilot)
  • add test route to routes.py
  • harness: Hyundai L
  • architecture: CAN-FD

Confirm

  • Hyundai L is the right harness, rule out Hyundai P (HDA vs non-HDA2)
  • radar/camera scc
  • _LAMP_ALT signals
  • sport/snow modes

Issues

  • "Check Lane Safety system" constant fault when not standstill, lane change, engaged
  • latitude: delayed steering response (tuning/scaling)
  • "Consider taking a break"
  • longitude: clicking actuator noises (may be experimental mode only)
  • latitude: oversteering
  • longitude: harsh braking

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sshane
Copy link
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

@sshane sshane closed this Aug 20, 2024
@royjr royjr deleted the kona-2nd-gen-port branch August 20, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants